Skip to content

Triage BaseController member visibility #2

@bitpshr

Description

@bitpshr

The notify method is exposed publicly on the BaseController, but it should be protected. It's an anti-pattern for notification to be triggered externally since it should already be triggered on every supported state change.

We should also triage all member visibility on the BaseController.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions