Skip to content

Add Async API #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 23, 2019
Merged

Add Async API #59

merged 9 commits into from
Nov 23, 2019

Conversation

Matthiee
Copy link
Member

@Matthiee Matthiee commented Nov 22, 2019

Fixes #1 async api part.

@Matthiee Matthiee added the enhancement New feature or request label Nov 22, 2019
@Matthiee Matthiee added this to the 0.3.vNext milestone Nov 22, 2019
@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #59 into 0.3 will increase coverage by 6.05%.
The diff coverage is 87.3%.

@@            Coverage Diff             @@
##              0.3      #59      +/-   ##
==========================================
+ Coverage   84.57%   90.62%   +6.05%     
==========================================
  Files          43       43              
  Lines        1037     1152     +115     
==========================================
+ Hits          877     1044     +167     
+ Misses        160      108      -52

@Matthiee Matthiee changed the title WIP Add Async API Add Async API Nov 23, 2019
@Matthiee Matthiee self-assigned this Nov 23, 2019
@Matthiee Matthiee merged commit 3fe4872 into 0.3 Nov 23, 2019
@Matthiee Matthiee mentioned this pull request Nov 23, 2019
4 tasks
@Matthiee Matthiee deleted the async-api branch November 23, 2019 08:58
@Matthiee Matthiee mentioned this pull request Feb 23, 2020
Matthiee added a commit that referenced this pull request Feb 23, 2020
* Add DefaultResolver (#58)

* Add default resolver that is capable of resolving types with string constructor. Fixes #57

* Add TryParse method detection

* Add Parse method finder as well.

* Add last test for Parse method

* Add Async API (#59)

* Add async api

* Add an async api for validations

* Add first async api test

* Add more async tests

* Add more async test cases

* Use Async version when parsing commands as well.

* Add validation tests

* Improve test coverage

* Fixes some styling issues spotted by codefactor.io (#62)

* Only display usages when no default values have been specified. (#63)

Fixes #60

* Fix code styling

* Update project to v0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants