-
Notifications
You must be signed in to change notification settings - Fork 478
Docs changes for Sql Server launch #33599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA. |
@kay-kim could we review this, and stage for release? Let's not merge it in yet though - still need a couple of additional fixes to go live! |
I have read the Contributor License Agreement (CLA) and I hereby sign the CLA. |
@@ -241,8 +241,7 @@ scenarios, we recommend separating your workloads into multiple clusters for | |||
{{< note >}} | |||
For a new SQL Server source, if none of the replicating tables | |||
are receiving write queries, snapshotting may take up to an additional 5 minutes | |||
to complete. For details, see [Snapshot latency for inactive | |||
databases](#considerations). | |||
to complete. For details, see [snapshot latency for inactive databases](/sql/create-source/sql-server/#snapshot-latency-for-inactive-databases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just link to the section on the same page?
So (#snapshot-latency-for-inactive-databases)
instead of the one on the create source reference page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about linking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you! I'll merge these once all the other changes for sql-server are live. |
What's changed?