Skip to content

Conversation

maheshwarip
Copy link

@maheshwarip maheshwarip commented Sep 16, 2025

What's changed?

  • Updates to docs
  • Removed private preview flags
  • Fixed typos

@maheshwarip maheshwarip requested a review from a team as a code owner September 16, 2025 17:25
Copy link

github-actions bot commented Sep 16, 2025

All contributors have signed the CLA.
Posted by the CLA Assistant Lite bot.

@maheshwarip maheshwarip marked this pull request as draft September 16, 2025 17:25
@maheshwarip maheshwarip marked this pull request as ready for review September 18, 2025 13:36
@maheshwarip
Copy link
Author

@kay-kim could we review this, and stage for release? Let's not merge it in yet though - still need a couple of additional fixes to go live!

@maheshwarip
Copy link
Author

I have read the Contributor License Agreement (CLA) and I hereby sign the CLA.

@@ -241,8 +241,7 @@ scenarios, we recommend separating your workloads into multiple clusters for
{{< note >}}
For a new SQL Server source, if none of the replicating tables
are receiving write queries, snapshotting may take up to an additional 5 minutes
to complete. For details, see [Snapshot latency for inactive
databases](#considerations).
to complete. For details, see [snapshot latency for inactive databases](/sql/create-source/sql-server/#snapshot-latency-for-inactive-databases)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just link to the section on the same page?
So (#snapshot-latency-for-inactive-databases) instead of the one on the create source reference page?

https://preview.materialize.com/materialize/33599/ingest-data/sql-server/self-hosted/#snapshot-latency-for-inactive-databases

Copy link
Contributor

@kay-kim kay-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about linking.

Copy link
Contributor

@kay-kim kay-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maheshwarip
Copy link
Author

Thank you! I'll merge these once all the other changes for sql-server are live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants