Skip to content

Fix bug in query handling where map-meta in query response was #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix bug in query handling where map-meta in query response was #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/map-feature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,9 @@ export class MapFeature extends HTMLElement {
let map = this._map,
geometry = this.querySelector('map-geometry'),
native = this._getNativeZoomAndCS(
this._layer._content || this._layer.metas
this._layer.queryMetas?.length
? this._layer.queryMetas
: this._layer._content
),
cs = geometry.getAttribute('cs') || native.cs,
// zoom level that the feature rendered at
Expand Down
10 changes: 7 additions & 3 deletions src/mapml/handlers/QueryHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ export var QueryHandler = L.Handler.extend({
features = Array.prototype.slice.call(
mapmldoc.querySelectorAll('map-feature')
);
// <map-meta> elements
layer.metas = Array.prototype.slice.call(
// <map-meta> elements for this query
layer.queryMetas = Array.prototype.slice.call(
mapmldoc.querySelectorAll(
'map-meta[name=cs], map-meta[name=zoom], map-meta[name=projection]'
)
Expand Down Expand Up @@ -298,7 +298,11 @@ export var QueryHandler = L.Handler.extend({
layer.on('popupclose', function () {
map.removeLayer(f);
});
f.showPaginationFeature({ i: 0, popup: layer._popup, meta: layer.metas });
f.showPaginationFeature({
i: 0,
popup: layer._popup,
meta: layer.queryMetas
});
}
}
});