Skip to content

Remove opinionated color of popup's close button #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2021
Merged

Remove opinionated color of popup's close button #349

merged 1 commit into from
Mar 11, 2021

Conversation

@Malvoz
Copy link
Member

@Malvoz Malvoz commented Mar 11, 2021 •
edited
Loading

Close #348.

Popup's close button now conforms to all of the following WCAG success criteria:

@Malvoz Malvoz requested review from ahmadayubi and prushforth March 11, 2021 17:44
@Malvoz Malvoz merged commit f00dfee into Maps4HTML:master Mar 11, 2021
@Malvoz Malvoz deleted the popup-close-button-contrast branch March 11, 2021 22:19
@Malvoz Malvoz removed the request for review from ahmadayubi March 11, 2021 22:24
@Malvoz Malvoz mentioned this pull request Mar 16, 2021
Open
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prushforth prushforth prushforth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Popup's close button has too low contrast

2 participants

@Malvoz @prushforth