Skip to content

Conditionally add controls based on map size #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Conditionally add controls based on map size #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/mapml-viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,9 @@ export class MapViewer extends HTMLElement {
setControls(isToggle, toggleShow, setup){
if (this.controls && this._map) {
let controls = ["_zoomControl", "_reloadButton", "_fullScreenControl", "_layerControl"],
options = ["nozoom", "noreload", "nofullscreen", 'nolayer'];
options = ["nozoom", "noreload", "nofullscreen", 'nolayer'],
mapSize = this._map.getSize().y,
totalSize = 0;

//removes the left hand controls, if not done they will be re-added in the incorrect order
//better to just reset them
Expand All @@ -255,13 +257,16 @@ export class MapViewer extends HTMLElement {
this._map.fire("validate");
}
}
if (!this.controlslist.toLowerCase().includes("nozoom") && !this._zoomControl){
if (!this.controlslist.toLowerCase().includes("nozoom") && !this._zoomControl && (totalSize + 93) <= mapSize){
totalSize += 93;
this._zoomControl = L.control.zoom().addTo(this._map);
}
if (!this.controlslist.toLowerCase().includes("noreload") && !this._reloadButton){
if (!this.controlslist.toLowerCase().includes("noreload") && !this._reloadButton && (totalSize + 49) <= mapSize){
totalSize += 49;
this._reloadButton = M.reloadButton().addTo(this._map);
}
if (!this.controlslist.toLowerCase().includes("nofullscreen") && !this._fullScreenControl){
if (!this.controlslist.toLowerCase().includes("nofullscreen") && !this._fullScreenControl && (totalSize + 49) <= mapSize){
totalSize += 49;
this._fullScreenControl = L.control.fullscreen().addTo(this._map);
}
//removes any control layers that are not needed, either by the toggling or by the controlslist attribute
Expand Down
13 changes: 9 additions & 4 deletions src/web-map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,9 @@ export class WebMap extends HTMLMapElement {
setControls(isToggle, toggleShow, setup){
if (this.controls && this._map) {
let controls = ["_zoomControl", "_reloadButton", "_fullScreenControl", "_layerControl"],
options = ["nozoom", "noreload", "nofullscreen", 'nolayer'];
options = ["nozoom", "noreload", "nofullscreen", 'nolayer'],
mapSize = this._map.getSize().y,
totalSize = 0;

//removes the left hand controls, if not done they will be re-added in the incorrect order
//better to just reset them
Expand All @@ -291,13 +293,16 @@ export class WebMap extends HTMLMapElement {
this._map.fire("validate");
}
}
if (!this.controlslist.toLowerCase().includes("nozoom") && !this._zoomControl){
if (!this.controlslist.toLowerCase().includes("nozoom") && !this._zoomControl && (totalSize + 93) <= mapSize){
totalSize += 93;
this._zoomControl = L.control.zoom().addTo(this._map);
}
if (!this.controlslist.toLowerCase().includes("noreload") && !this._reloadButton){
if (!this.controlslist.toLowerCase().includes("noreload") && !this._reloadButton && (totalSize + 49) <= mapSize){
totalSize += 49;
this._reloadButton = M.reloadButton().addTo(this._map);
}
if (!this.controlslist.toLowerCase().includes("nofullscreen") && !this._fullScreenControl){
if (!this.controlslist.toLowerCase().includes("nofullscreen") && !this._fullScreenControl && (totalSize + 49) <= mapSize){
totalSize += 49;
this._fullScreenControl = L.control.fullscreen().addTo(this._map);
}
//removes any control layers that are not needed, either by the toggling or by the controlslist attribute
Expand Down