Adjust for Stable features lint #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can affect downstream crates when a new nightly version is released
|
That ... shouldn't be happening. Cargo caps lints for dependencies to |
|
@Manishearth It was unexpected to me too, I assume the attribute overrides it? Here's a log which is I guess it might just be an oversight that |
|
No, it's not supposed to. That's the point of capping lints 😄 File a cargo bug, I guess. |
|
Pushed a fix upstream, cargo didn't seem to be the correct place for it (would have required considerable change). Do you want me to drop the second commit as it should in theory get fixed in future? Will still require the first commit to allow downstream to not fail though so it would be good if we could merge that! |
Manishearth
added a commit
that referenced
this pull request
Nov 3, 2015
Adjust for Stable features lint
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 3, 2015
This sets the `cap-lints` setting to 'allow' for all doc compilations. There's precedent for this as rustdoc [already whitelists unstable code](https://github.com/rust-lang/rust/blob/master/src/librustdoc/core.rs#L112) when compiling documentation, with the expectation being that a regular compile will complain about any problems. I think the same justification applies here. Problem case in the wild: Manishearth/compiletest-rs#28 r? @Manishearth
critiqjo
pushed a commit
to critiqjo/rustdoc
that referenced
this pull request
Dec 16, 2016
This sets the `cap-lints` setting to 'allow' for all doc compilations. There's precedent for this as rustdoc [already whitelists unstable code](https://github.com/rust-lang/rust/blob/master/src/librustdoc/core.rs#L112) when compiling documentation, with the expectation being that a regular compile will complain about any problems. I think the same justification applies here. Problem case in the wild: Manishearth/compiletest-rs#28 r? @Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deny warnings doesn't seem very future-proofed, perhaps you want to
deny(warnings)specifically on travis or something viacargo rustc -- -F warnings?For reference, this killed the nickel build when
cargo docwas being run.