Skip to content

Conversation

@Aathish04
Copy link
Member

Renames the Scripts folder to scripts.

Removes trailing whitespaces in Scripts/pycairoinstall.py

@leotrs
Copy link
Contributor

leotrs commented May 26, 2020

Does it actually? The diff only shows the whitespaces being removed

Aathish Sivasubrahmanian added 2 commits May 26, 2020 18:09
@Aathish04
Copy link
Member Author

Does it actually? The diff only shows the whitespaces being removed

Huh, apparently git doesn't care about directory renames.

@naveen521kk
Copy link
Member

I also tried the same and got disappointed. @Aathish04

@Aathish04
Copy link
Member Author

Aathish04 commented May 26, 2020

I also tried the same and got disappointed. @Aathish04

You could have told us then. It's not a noticeable change...

Regardless, it's fixed now.

Waiting for another reviewer, after which it can be merged

@naveen521kk
Copy link
Member

naveen521kk commented May 26, 2020

Wait. Update the link in Readme also. Its invalid. Update with this link. Its case sensitive. Lol. Check out @Aathish04
https://raw.githubusercontent.com/ManimCommunity/manim/master/Scripts/pycairoInstall.py

@Aathish04
Copy link
Member Author

Aathish04 commented May 26, 2020

Wait. Update the link in Readme also. Its invalid. Update with this link. Its case sensitive. Lol. Check out @Aathish04
https://raw.githubusercontent.com/ManimCommunity/manim/master/Scripts/pycairoInstall.py

@naveen521kk

The URL in the master branch is the proper one.

It points to https://raw.githubusercontent.com/ManimCommunity/manim/master/scripts/pycairoInstall.py

Which is what the link should be.

After this is merged, the proper file will be in that location, but as of now, since you didn't rename to folder to scripts instead of Scripts, it points to a file that doesn't exist.

The only reason that link you quoted still works is because the file's location hasn't been changed in the master branch yet, only in fix-91

@Aathish04 Aathish04 merged commit 928b136 into master May 26, 2020
@PgBiel PgBiel added pr:bugfix Bug fix for use in PRs solving a specific issue:bug infrastructure Anything related to our infrastructure labels May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Anything related to our infrastructure pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants