Updaters fix #838
Merged
Updaters fix #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:dependent
github-actions
bot
removed
the
pr:dependent
Contributor
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
Member
Author
|
These videos showcase the difference between the code with and without the fix; both were rendered from the same script. not-fixed.mp4fixed.mp4 |
behackl
approved these changes
Dec 21, 2020
Member
behackl
left a comment
behackl
left a comment
There was a problem hiding this comment.
LGTM. I also agree with your assessment that the removal of submobjects currently is ... unintuitive, and should be refactored eventually.
(I also checked the rendered animations in our documentation for good measure, they all still seem fine.)
huguesdevimeux
approved these changes
Dec 23, 2020
Member
huguesdevimeux
left a comment
huguesdevimeux
left a comment
There was a problem hiding this comment.
SGTM.
A test would be useful IMO.
huguesdevimeux
previously requested changes
Dec 23, 2020
huguesdevimeux
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Update
Scene.moving_mobjectsinScene.add(). Depends on #830 for its Scene refactoring.Motivation
When a mobject is added by an updater in the middle of an animation,
Scene.moving_mobjectsisn't updated. As a result, the added mobject won't appear in the Scene.Changelog Entry
Mobjects added during an updater are added to Scene.moving_mobjects.
Testing Status
As long as we can only test the final frame this change can't be tested.
Further Comments
The way that manim removes submobjects within a group by splitting the group apart and re-adding the parts that weren't removed is very strange. It make much more sense to me to remove submobjects by removing the reference in their parent's submobjects list and leave out the logic in
Scene.restructure_mobjects()entirely. In particular, I've never encountered another graphics program that handles nested objects the way manim currently does.Acknowledgements
docs/source/changelog.rst