Skip to content

Conversation

@cobordism
Copy link
Member

I replaced https://manimce.readthedocs.io with https://docs.manim.community

I changed one link of https://pypi.org/project/manimce to https://pypi.org/project/manim
Note: it looks like manim is still on version 0.1.0 while manimce is 0.1.1. This should not be. manim should be the newest version, manimce should redirect to manim ... or sth like that, no?

I did not change the line choco install manimce because I have no idea about choco

@cobordism cobordism added the pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! label Dec 5, 2020
@leotrs
Copy link
Contributor

leotrs commented Dec 5, 2020

Pinging @eulertour about pypi and @naveen521kk about choco

@naveen521kk
Copy link
Member

I did not change the line choco install manimce because I have no idea about choco

I am sorry. That would be manimce until we release a version 1.0.0. There was some problem with manim choco package that it had version 1.0.0 already released so other version wasn't able to work. Let it be manimce for now.

@leotrs
Copy link
Contributor

leotrs commented Dec 5, 2020

Perhaps we should add a warning or note admonition to the docs saying that.

@eulertour
Copy link
Member

I don't know anything about the choco package, but otherwise LGTM

Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naveen521kk naveen521kk changed the title No more manimce in URLs Rename Docs Url Dec 7, 2020
@naveen521kk naveen521kk changed the title Rename Docs Url Update Docs Url Dec 7, 2020
@naveen521kk naveen521kk merged commit 247cdee into ManimCommunity:master Dec 7, 2020
@cobordism cobordism deleted the no-more-manimce branch April 7, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants