Skip to content

Conversation

@zavden
Copy link
Contributor

@zavden zavden commented May 25, 2020

With these modifications we avoid having to install the texlive-fonts-extra package.

@TonyCrane
Copy link
Contributor

But sometimes physics is useful

Copy link
Member

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep physics at least
I'm also not sure if manim depends on xcolor so might wanna keep that as well

@PgBiel PgBiel added the pr:deprecation Deprecation, or removal of deprecated code label May 25, 2020
@PhilippImhof
Copy link
Member

Same for dsfont. In mathematical contexts, we use these double stroke letters a lot, depending on the subject. Especially in school settings, where these animations are particularly useful. Most people using manim will probably have a full LaTeX distribution installed anyway.

If this gets merged, my PR for customization of the TeX template might come in handy, because people who still need those packages could easily add them even on a per project basis.

@leotrs
Copy link
Contributor

leotrs commented May 27, 2020

@zavden thanks for your contribution! Could you please revise your PR with the changes noted by @PhilippImhof and @PgBiel?

@PgBiel
Copy link
Member

PgBiel commented May 28, 2020

@zavden thanks for your contribution! Could you please revise your PR with the changes noted by @PhilippImhof and @PgBiel?

pretty sure if all changes are applied then this PR becomes pretty much useless, so we might want to discuss this further

I think we should wait for #48 first

@zavden
Copy link
Contributor Author

zavden commented May 28, 2020

It seems to me that the fundamental thing is to leave Manim with the minimum packages needed for operation, since this avoids installing unnecessary packages.

@leotrs
Copy link
Contributor

leotrs commented May 28, 2020 via email

@zavden zavden closed this May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:deprecation Deprecation, or removal of deprecated code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants