Skip to content

Conversation

@naveen521kk
Copy link
Member

List of Changes

I think it is time to remove python 3.6 from testing and soon remove support for it. This is done because running CI takes longer than expected and testing three major python version seem satisfying. This is not depreciating it but just not running the tests in CI.

  • Don't test python 3.6

Motivation

CI takes a lot of time to run and has pending.

Explanation for Changes

Remove testing for python 3.6.

Acknowledgements

I think it is time to remove python 3.6 from testing and soon remove support for it. This is done because running CI takes longer that expected and testing three major python version seem satisfying.
@leotrs
Copy link
Contributor

leotrs commented Dec 3, 2020

Pro of this PR: the macos py3.6 test seems to consistently take the longest time to run.

Con of this PR: python3.6 reaches end of life at the end of next year.

Perhaps we can disable py3.6 tests for now but still try to provide help/support for users on py3.6 if they run into issues.

Although it might just be better to forget about 3.6 altogether already...

@naveen521kk
Copy link
Member Author

Perhaps we can disable py3.6 tests for now but still try to provide help/support for users on py3.6 if they run into issues.

I think we can do this.

@leotrs
Copy link
Contributor

leotrs commented Dec 3, 2020

cc @eulertour

@kolibril13
Copy link
Member

Is it possible to remove this test in the pr workflow and shift it to another GitHub action that runs it once every week?

@naveen521kk
Copy link
Member Author

I don't think it is required. Simply disable test for python 3.6 but not actually drop support for it.

@naveen521kk naveen521kk requested a review from eulertour December 5, 2020 11:32
@naveen521kk
Copy link
Member Author

Any objection in merging this?

@leotrs
Copy link
Contributor

leotrs commented Dec 5, 2020

Not from me ,just waiting on pending review by @eulertour

@kolibril13 kolibril13 merged commit 1318db5 into master Dec 5, 2020
@kolibril13 kolibril13 deleted the remove-3.6 branch December 5, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants