-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Pycairo install Made Easy Using single Command #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Further, we can change the URL from my personal gist after merging. |
|
Can you please change |
|
@naveen521kk thank you for addressing my comments. I think this is a good contribution, but I would like to have it tested somehow before merging. I'm assuming you tested this on your machine. Have you tested it in other machines? |
|
I have tested on my PC which runs windows 7 and AMD 64 processor it worked perfectly. Further, I tried it out with my windows 10 PC with 32-bit processor. Both the machine installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When doing pip install, I think you can use the return value of os.system to see if it was installed correctly, so you don't print "Succesfully installed Cairo" if there was an error.
|
Is there some dynamic way for it to detect whether you need |
|
|
|
|
|
@safinsingh I think this new command would help. (Invoke-WebRequest -Uri https://raw.githubusercontent.com/ManimCommunity/manim/master/scripts/pycairoInstall.py -UseBasicParsing).Content | py -3Above thing works only when this is merged. |
|
I added Python 3.6 Support to this file in this PR: https://github.com/ManimCommunity/manim/blob/ab9ac29f3be1287d6e6c9ff39d2fbf29e838ce0c/.travis/cairo-windows.py. Once this PR is merged, we'll need to use this file instead because it has Python 3.6 support. |
|
Have anybody tried those command and did it work? |
|
Pinging @kilacoda for a requested review, and @Aathish04 to double check whether the changes they requested have been made :) |
Aathish04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested have been addressed.

Fixed Pycairo installation for windows user.
Running above command installs
pycairo. Supports Windows7+ with elevated Command Prompt like Powershell. Further it supports, python 3.7 and 3.8 and x86 PC and AMD64 PC.Fix #14 .