-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Bring back support for docker #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
naveen521kk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and nit picks.
Co-authored-by: Naveen M K <[email protected]>
Co-authored-by: Naveen M K <[email protected]>
naveen521kk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
The latest commit, 60bbfdf just adds a badge for the docker image to our readme -- and it also fixes the fact that our badges currently don't link correctly. |
|
As a nit, the capital "D" on the docker badge looks sort of out of place since all of the others but CI use only lowercase letters. |
No: there is a short description of how to use the image by mounting the current working directory into it, the videos are then placed outside the container. :-) Edit: the description is on dockerhub, https://hub.docker.com/r/manimcommunity/manim |
|
Let's merge, we can always move forwards on follow-up PRs. |
This PR adds a simple Dockerfile corresponding to the image currently available at https://hub.docker.com/r/manimcommunity/manim.
Motivation
This provides a very easy and low-effort option for people who do not want to care about getting the manim installation process right.
Testing Status
After running
pip install pytestand then actually runningpytestin a docker container with this image passes all tests.Further Comments
We (@ManimCommunity/docker) should develop a strategy for which versions of this image should exist. Currently, I am in favor of providing a tagged image per released version; I am not sure about having a
latesttag that is in sync withmasterfrom this repository. If we add something like that, I'd rather call itunstableor so... And we could think about having astabletag mirroring ourstablebranch.Anyhow, we don't have to fully decide on a policy before merging this -- the image is, in fact, already available; I'd just like to add the Dockerfile to the repository.
Acknowledgement