More examples for the docs #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolibril13
commented
Oct 8, 2020
Contributor
|
@kolibril13 you assigned Ben and me to this PR. I think you may have meant to ask us for a review. Note these two are different things. You can ask for a review at the top right (just above the "asignees" part). |
leotrs
reviewed
Oct 12, 2020
Contributor
leotrs
left a comment
leotrs
left a comment
There was a problem hiding this comment.
Beautiful! Just left a few minor comments.
behackl
requested changes
Oct 12, 2020
Member
behackl
left a comment
behackl
left a comment
There was a problem hiding this comment.
This looks really good to me! Please consider my suggestion regarding the filled arrow tips - and I am not sure whether the comment you added at some point regarding referencing something from the reference manual is still open; let me know if you intend to do something with that.
Co-authored-by: Benjamin Hackl <[email protected]>
behackl
approved these changes
Oct 12, 2020
Member
behackl
left a comment
behackl
left a comment
There was a problem hiding this comment.
I thik this is good to go. Great additions!
leotrs
reviewed
Oct 12, 2020
Co-authored-by: Leo Torres <[email protected]>
leotrs
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some more examples for the example section of the docs