Skip to content

Set canvas size based on text length #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Set canvas size based on text length #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e73d01e
set canvas size based on text length
behackl Sep 24, 2020
650d152
add test
behackl Sep 24, 2020
27dae43
warning for very large font sizes
behackl Sep 28, 2020
ecb135c
Merge branch 'master' of github.com:ManimCommunity/manim into text-ca…
behackl Oct 25, 2020
9243526
apply same fix to PangoText
behackl Oct 25, 2020
3339e95
RTL text seems to require more space per character; add a correspondi…
behackl Oct 25, 2020
3b96b52
Merge remote-tracking branch 'origin/master' into text-canvas-size
behackl Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions manim/mobject/svg/text_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ def __init__(self, text, **config):
self.line_spacing = self.size + self.size * 0.3
else:
self.line_spacing = self.size + self.size * self.line_spacing
if self.size > 800:
logger.warning(
"Using a font size larger than 800 can lead to render problems."
" See https://github.com/ManimCommunity/manim/pull/476 for details."
)
file_name = self.text2svg()
self.remove_last_M(file_name)
SVGMobject.__init__(self, file_name, **config)
Expand Down Expand Up @@ -318,7 +323,7 @@ def text2svg(self):
file_name = os.path.join(dir_name, hash_name) + ".svg"
if os.path.exists(file_name):
return file_name
surface = cairo.SVGSurface(file_name, 600, 400)
surface = cairo.SVGSurface(file_name, 4 * len(self.text) * size, 400)
context = cairo.Context(surface)
context.set_font_size(size)
context.move_to(START_X, START_Y)
Expand Down Expand Up @@ -684,6 +689,11 @@ def __init__(self, text: str, **config): # pylint: disable=redefined-outer-name
self.line_spacing = self.size + self.size * 0.3
else:
self.line_spacing = self.size + self.size * self.line_spacing
if self.size > 800:
logger.warning(
"Using a font size larger than 800 can lead to render problems."
" See https://github.com/ManimCommunity/manim/pull/476 for details."
)
file_name = self.text2svg()
self.remove_last_M(file_name)
SVGMobject.__init__(self, file_name, **config)
Expand Down Expand Up @@ -891,7 +901,7 @@ def text2svg(self):
file_name = os.path.join(dir_name, hash_name) + ".svg"
if os.path.exists(file_name):
return file_name
surface = cairocffi.SVGSurface(file_name, 600, 400)
surface = cairocffi.SVGSurface(file_name, 4 * len(self.text) * size, 400)
context = cairocffi.Context(surface)
context.move_to(START_X, START_Y)
settings = self.text2settings()
Expand Down
9 changes: 9 additions & 0 deletions tests/test_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from manim import Text


def test_long_string():
"""Check that `#469 <https://github.com/ManimCommunity/manim/issues/469>`_
is resolved."""

t = Text("a" * 150, font="Arial")
assert len(t.text) == len(t.submobjects)