Skip to content

Conversation

@rvodden
Copy link

@rvodden rvodden commented Oct 31, 2025

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Fixes #4462

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@henrikmidtiby
Copy link
Contributor

Thanks for the PR.

I consider if the workaround provided here #4462 (comment) would be enough, or whether we have to add this functionality to the code base.
If it should be added to the code base, some tests of get_scene_classes_from_module and scene_classes_from_file should be added to this PR.

@rvodden
Copy link
Author

rvodden commented Nov 1, 2025

Thanks @henrikmidtiby - I can easily add those tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

Manim cannot render imported Scenes

2 participants