Skip to content

refactor: rename Torus field 'r' to 'minor_radius' for clarity #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: rename Torus field 'r' to 'minor_radius' for clarity #4461

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0e841f
refactor: rename Torus field 'r' to 'minor_radius' for clarity
Oct 29, 2025
7474032
fixed intendation
Oct 29, 2025
22a45bb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions manim/mobject/three_d/three_dimensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,7 @@ def __init__(
resolution = resolution if resolution is not None else res_value

self.R = major_radius
self.r = minor_radius
self.minor_radius = minor_radius
super().__init__(
self.func,
u_range=u_range,
Expand All @@ -1272,4 +1272,6 @@ def func(self, u: float, v: float) -> np.ndarray:
The z values defining the :class:`Torus`.
"""
P = np.array([np.cos(u), np.sin(u), 0])
return (self.R - self.r * np.cos(v)) * P - self.r * np.sin(v) * OUT
return (
self.R - self.minor_radius * np.cos(v)
) * P - self.minor_radius * np.sin(v) * OUT