Skip to content

Conversation

@fmuenkel
Copy link
Contributor

@fmuenkel fmuenkel commented Aug 6, 2025

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

This PR makes a few tests pass mainly by fixing incorrect imports. It also fixes a few docstrings and silences mypy by ignoring errors in manim/cli and manim/mobject/geometry.

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall, thanks!

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Aug 9, 2025
@JasonGrace2282 JasonGrace2282 merged commit 36bb003 into ManimCommunity:experimental Aug 9, 2025
3 of 4 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Aug 9, 2025
@fmuenkel fmuenkel deleted the fix-import branch August 9, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants