Fix n flag #422
Closed
Fix n flag #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pg Biel <[email protected]> Co-authored-by: Leo Torres <[email protected]>
huguesdevimeux
requested review from
Aathish04,
PgBiel,
behackl,
leotrs and
naveen521kk
and removed request for
PgBiel,
behackl and
leotrs
Member
Author
|
Closing this in favor of #423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT
Wut It appears that I messed something up with the branches. This is rebased from #403
ONLY THE LAST TWO COMMITS ARE THE PR !
SO PLEASE WAIT FOR #403 PR TO BE MERGED FIRST !
List of Changes
Explanation for Changes
I modified the mechanism behind -n flag. Before, manim rendered all the partial movie files and selected only the ones with the index between i and j (where i and j are integreers passed with -n flag, eg
-n 5,6).Now, it skips the entire process if an animation is outside the [i,j] interval and creates partial movies files otherwise.
Testing Status
Created a test for n flag in
test_scene_rendering/test_cli_flags.py