Skip to content

Fix File Not Found Error - Github Actions #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2020
Merged

Fix File Not Found Error - Github Actions #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa9d8dd
Fix File Not Found Error
naveen521kk Sep 5, 2020
daf41c4
Remove Schedule
naveen521kk Sep 5, 2020
a6d49df
Remove trailing space
naveen521kk Sep 5, 2020
e93330d
Add check for moved files
naveen521kk Sep 5, 2020
b1157ee
Check for .py and not py
naveen521kk Sep 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/black-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
$commitEndpoint=$($payload.pull_request._links.commits.href)
echo "$commitEndpoint"
$commits = Invoke-WebRequest -Uri "$commitEndpoint" | ConvertFrom-Json
bash -c "git diff --name-only HEAD HEAD~$($commits.count)>/d/changes.txt"
bash -c "git diff --name-only HEAD~$($commits.count) HEAD>/d/changes.txt"

- name: Run Black on top of latest commit
shell: bash
Expand All @@ -45,14 +45,14 @@ jobs:
content=$(</d/changes.txt)
while read file
do
if [ $(python -c "print('${file}'[-2:])") == "py" ]
if [[ ($(python -c "print('${file}'[-3:])") == ".py") && (-f ${file}) ]]
then
black --diff $file
fi
done </d/changes.txt
while read file
do
if [ $(python -c "print('${file}'[-2:])") == "py" ]
if [[ ($(python -c "print('${file}'[-3:])") == ".py") && (-f ${file}) ]]
Copy link
Member

@Aathish04 Aathish04 Sep 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some reservations about using Python instead of Bash for this conditional, but its something we can come back and fix.

This works for the time being, and we have multiple PRs waiting for this one, so approved!

then
black $file
fi
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/black.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: black
on:
workflow_dispatch:
schedule:
- cron: "0 0 * * *"

jobs:
format:
Expand Down