Skip to content

[EXPERIMENTAL] Remove ThreeDScene and rewrite Camera internals #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 17, 2024
Merged

[EXPERIMENTAL] Remove ThreeDScene and rewrite Camera internals #4059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8b90f4d
Add ThreeDScene and rewrite Camera internals
chopan050 Dec 15, 2024
ae04878
Log warning when using Camera.rotate() and add docstrings to Euler an…
chopan050 Dec 15, 2024
5bfa6dc
Add Camera.set_focal_distance()
chopan050 Dec 15, 2024
7b5a1bd
Delete ThreeDScene
chopan050 Dec 16, 2024
de6ffc7
Modify references to Camera.set_orientation() and similar stuff
chopan050 Dec 16, 2024
c26b5cb
Merge branch 'experimental' of https://github.com/ManimCommunity/mani…
chopan050 Dec 16, 2024
f8496e4
Add InvisibleMobject and allow rendering submobjects of Group or Open…
chopan050 Dec 16, 2024
898419d
MobClass -> mob_cls
chopan050 Dec 16, 2024
e46e079
Add oneline summary to InvisibleMobject
chopan050 Dec 16, 2024
5f2edcd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 16, 2024
78adf30
Final removal of ThreeDScene in docs
chopan050 Dec 17, 2024
3c81973
VectorSpaceScene -> VectorScene
chopan050 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/i18n/gettext/reference/manim.mobject.three_d.three_dimensions.Line3D.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ msgid "Bases: :py:class:`manim.mobject.three_d.three_dimensions.Cylinder`"
msgstr ""

#: ../../../manim/mobject/three_d/three_dimensions.py:docstring of manim.mobject.three_d.three_dimensions.Line3D:1
msgid "A cylindrical line, for use in ThreeDScene."
msgid "A cylindrical line."
msgstr ""

#: ../../../manim/mobject/three_d/three_dimensions.py:docstring of manim.mobject.three_d.three_dimensions.Line3D:4
Expand Down
2 changes: 1 addition & 1 deletion docs/i18n/gettext/reference/manim.mobject.three_d.three_dimensions.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ msgid "A spherical dot."
msgstr ""

#: ../../source/reference/manim.mobject.three_d.three_dimensions.rst:40:<autosummary>:1
msgid "A cylindrical line, for use in ThreeDScene."
msgid "A cylindrical line."
msgstr ""

#: ../../source/reference/manim.mobject.three_d.three_dimensions.rst:40:<autosummary>:1
Expand Down
97 changes: 0 additions & 97 deletions docs/i18n/gettext/reference/manim.scene.three_d_scene.SpecialThreeDScene.pot
View file
Open in desktop

This file was deleted.

210 changes: 0 additions & 210 deletions docs/i18n/gettext/reference/manim.scene.three_d_scene.ThreeDScene.pot
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions docs/source/contributing/testing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,11 +213,11 @@ The decorator can be used with or without parentheses. **By default, the test on
circle = Circle()
scene.play(Animation(circle))

You can also specify, when needed, which base scene you need (ThreeDScene, for example) :
You can also specify, when needed, which base scene you need (VectorScene, for example) :

.. code:: python

@frames_comparison(last_frame=False, base_scene=ThreeDScene)
@frames_comparison(last_frame=False, base_scene=VectorScene)
def test_circle(scene):
circle = Circle()
scene.play(Animation(circle))
Expand Down
Loading
Loading