Experimental: fix 11 tests #3979
Conversation
chopan050
changed the title
Animation run time inside new run_time property setter| def test_wait_run_time_shorter_than_frame_rate(manim_caplog): | ||
| manager = Manager(Scene) | ||
| test_scene = manager.scene | ||
| test_scene.wait(1e-9, frozen_frame=frozen_frame) |
There was a problem hiding this comment.
We should probably get frozen_frame working instead of removing it from the test?
There was a problem hiding this comment.
frozen_frame was no longer among the parameters of the new Scene.wait(), so I assumed that it would no longer be needed.
I can put it there again, if it's necessary.
There was a problem hiding this comment.
Yeah, that might be my fault actually - I think I might have wanted to replace it with wait_until?
I guess for now until wait_until works this is fine.
| def test_ghost_vectors_len_and_types(): | ||
| manager = Manager(LinearTransformationScene) | ||
| scene = manager.scene | ||
| scene: LinearTransformationScene = manager.scene |
There was a problem hiding this comment.
It's interesting that we need this annotation - I thought it should be able to infer this already?
There was a problem hiding this comment.
Yeah. Honestly, I don't know why this happens.
JasonGrace2282
left a comment
JasonGrace2282
left a comment
There was a problem hiding this comment.
LGTM for now, we can always fix more tests later :)
2 participants
Overview: What does this pull request change?
run_timevalidation forAnimationandScene.wait()#3982 into this branch in order to pass most tests intests/module/animations/test_animations.py.Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist