Fix: .to_edge()'s example demonstration in docs
#3958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackl
approved these changes
Oct 15, 2024
Member
behackl
left a comment
behackl
left a comment
There was a problem hiding this comment.
Well spotted, thanks for fixing this!
I'll merge this as soon as our docs build properly again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
.to_edge()'s example demonstration in docsAdded the missing object (
c: Circle) in the scene demonstrating.to_edge(RIGHT)here -Motivation and Explanation:
The example on To Edge Example demonstrated the use of
.to_edge()method with three objects, two of them were added (in #3408) to the scene but one was missed. I was just reading through the docs, and was confused for a second looking for the missing circle.Links to added or changed documentation pages
https://manimce--3958.org.readthedocs.build/en/3958/reference/manim.mobject.mobject.Mobject.html#toedgeexample But this link doesn't seem to work
Reviewer Checklist
If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS sectionIf applicable: newly added functions and classes are tested