Skip to content

Conversation

@leotrs
Copy link
Contributor

@leotrs leotrs commented Aug 31, 2020

#330 broke MovingCamera and ZoomedScene. This is a quick attempt at a hotfix.

Draft since we're still working on it.

@leotrs leotrs requested a review from Aathish04 August 31, 2020 11:17
@leotrs leotrs self-assigned this Aug 31, 2020
@leotrs leotrs added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Aug 31, 2020
@leotrs leotrs marked this pull request as draft August 31, 2020 11:18
@Aathish04
Copy link
Member

Aathish04 commented Aug 31, 2020

@leotrs If it's fine, I'll add the test scene I used as a test for this once #335 is merged.

@Aathish04 Aathish04 added test requested Implementation of tests are requested waiting for another pr's merge labels Aug 31, 2020
@leotrs
Copy link
Contributor Author

leotrs commented Sep 2, 2020

@Aathish04 I believe we can come back to this and finish now.

@Aathish04
Copy link
Member

Alright, so I had originally intended to do pixel comparison tests, just like the ones that were done for Text, TexMobject and TextMobject. However, with #335 basically confirming that they are too erratic and way too precise to be of any use, I don't think that such a test will be useful in this case as well.

@leotrs @huguesdevimeux Do you have any other suggestions as to how a test for this could be written? I can't think of any straightforward ones, since even if the classes are broken, they could still render and the only difference would be in the final video.

@leotrs
Copy link
Contributor Author

leotrs commented Sep 2, 2020

This was intended to be a hotfix - can we merge it while we think of ways to test these?

@Aathish04
Copy link
Member

This was intended to be a hotfix - can we merge it while we think of ways to test these?

Yes, that would be good.

Adding this test to #193

@leotrs leotrs marked this pull request as ready for review September 2, 2020 18:17
@leotrs leotrs added pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! and removed test requested Implementation of tests are requested labels Sep 2, 2020
@leotrs leotrs merged commit ba004b8 into master Sep 9, 2020
@leotrs leotrs deleted the fix-zoomed-camera branch September 9, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants