-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix MovingCamera and ZoomedScene #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Aathish04 I believe we can come back to this and finish now. |
|
Alright, so I had originally intended to do pixel comparison tests, just like the ones that were done for @leotrs @huguesdevimeux Do you have any other suggestions as to how a test for this could be written? I can't think of any straightforward ones, since even if the classes are broken, they could still render and the only difference would be in the final video. |
|
This was intended to be a hotfix - can we merge it while we think of ways to test these? |
Yes, that would be good. Adding this test to #193 |
#330 broke MovingCamera and ZoomedScene. This is a quick attempt at a hotfix.
Draft since we're still working on it.