Skip to content

Fix rectangle grid properties (#3082) #3513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Fix rectangle grid properties (#3082) #3513

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f4c1c8
Import for both vertical and horizontal gridlines in
pauluhlenbruck Dec 11, 2023
d959ab6
Merge branch 'main' into 3082
MrDiver Dec 12, 2023
3f0a8e1
Merge branch 'main' into 3082
MrDiver Dec 12, 2023
d1a6c60
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions manim/mobject/geometry/polygram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,12 +619,16 @@ def __init__(
super().__init__(UR, UL, DL, DR, color=color, **kwargs)
self.stretch_to_fit_width(width)
self.stretch_to_fit_height(height)

v = self.get_vertices()
self.grid_lines = VGroup()

if grid_xstep is not None:
if grid_xstep or grid_ystep:
from manim.mobject.geometry.line import Line

v = self.get_vertices()

if grid_xstep:
grid_xstep = abs(grid_xstep)
count = int(width / grid_xstep)
grid = VGroup(
Expand All @@ -638,7 +642,8 @@ def __init__(
)
)
self.grid_lines.add(grid)
if grid_ystep is not None:

if grid_ystep:
grid_ystep = abs(grid_ystep)
count = int(height / grid_ystep)
grid = VGroup(
Expand Down