Add type hints to animation
#3457
Conversation
| def __init__( | ||
| self, | ||
| vmobject: VMobject, | ||
| rate_func: Callable[[float], float] = linear, |
There was a problem hiding this comment.
Should rate_func be passed to super? (i.e. in this case Write). It is currently unused.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self.suspend_mobject_updating: bool = suspend_mobject_updating | ||
| self.lag_ratio: float = lag_ratio | ||
| self._on_finish: Callable[[Scene], None] = _on_finish | ||
| self.run_time = run_time |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
| self.lag_ratio: float = lag_ratio | ||
| self._on_finish: Callable[[Scene], None] = _on_finish | ||
| self.run_time = run_time | ||
| self.rate_func = rate_func |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
| self.rate_func = rate_func | ||
| self.reverse_rate_function = reverse_rate_function | ||
| self.name = name | ||
| self.remover = remover |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
|
manim/manim/animation/creation.py Lines 122 to 130 in 4315549 |
| MappingFunction: TypeAlias = Callable[[Point3D], Point3D] | ||
| """A function mapping a `Point3D` to another `Point3D`.""" | ||
|
|
||
| RateFunc: TypeAlias = Callable[[float], float] |
Check notice
Code scanning / CodeQL
Unused global variable
It would seem so! |
|
Consider this a first pass. They are still too many mypy errors to actually enable this module. I first want to go over simple modules and I'll come back to this one later. |
JasonGrace2282
added
typehints
3 participants
Part of #3375.