Skip to content

Conversation

@behackl
Copy link
Member

@behackl behackl commented Oct 28, 2022

Overview: What does this pull request change?

Fixes #2563, fixes #2711: For Succsession, the animation run time was not processed correctly if the run_time attribute was set after creation of the animation object. This happens, for example, if the run_time keyword argument of Scene.play is passed like this:

self.play(
    Succession(anim1, anim2, ...),
    run_time=42
)

This also supersedes #2913. I have also included a test for this fix.

@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Oct 28, 2022
@behackl behackl mentioned this pull request Oct 28, 2022
3 tasks
Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@behackl behackl enabled auto-merge (squash) October 29, 2022 07:32
@behackl behackl merged commit 3c172e2 into ManimCommunity:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

Status: Done

2 participants