Skip to content

Conversation

@Darylgolden
Copy link
Member

@Darylgolden Darylgolden commented Jan 5, 2022

Overview: What does this pull request change?

Remove strings.py

Motivation and Explanation: Why and how do your changes improve the library?

The file isn't used anywhere in the library and doesn't even appear relevant to Manim.

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@Darylgolden Darylgolden marked this pull request as ready for review January 5, 2022 11:11
@behackl behackl added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label Jan 6, 2022
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it is fine to remove this.

@behackl behackl enabled auto-merge (squash) January 6, 2022 12:41
@behackl behackl merged commit 4c48f4f into ManimCommunity:main Jan 6, 2022
@behackl behackl changed the title Remove strings.py Removed strings.py Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants