Skip to content

Conversation

@mz71
Copy link
Contributor

@mz71 mz71 commented Aug 2, 2020

List of Changes

Fixing #225. (In short, TexMobject("\\{") is giving a LaTeX error.)

Motivation

To make compound TexMobjects consisting of literal braces, e.g. set-builder notation: TexMobject("\\{,"x","\mid","x>2","\\}")

Explanation for Changes

It's just a one-line fix, that substracts \\{ and \\} from the count. (It also adds back \\\\{ and \\\\} because those are not literal braces)

Testing Status

As this is just a one-line fix, I only provide the minimal example that didn't work

class LiteralBraceTest(Scene):
    def construct(self):
        a = TexMobject("\\{")
        self.add(a)

LiteralBraceTest
:

Acknowledgement

@leotrs
Copy link
Contributor

leotrs commented Aug 3, 2020

Great! Can we think of a quick test to add before merging?

@PgBiel PgBiel added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Aug 11, 2020
Copy link
Member

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with leo

@leotrs
Copy link
Contributor

leotrs commented Aug 15, 2020

@mz71 thoughts on adding tests so this never happens again?

@leotrs
Copy link
Contributor

leotrs commented Aug 23, 2020

Merging and adding to #193

@leotrs leotrs merged commit a3d2429 into ManimCommunity:master Aug 23, 2020
@huguesdevimeux huguesdevimeux mentioned this pull request Aug 23, 2020
15 tasks
@mz71
Copy link
Contributor Author

mz71 commented Aug 31, 2020

@mz71 thoughts on adding tests so this never happens again?

Sorry for late reply, probably bundling up some complicated Latex formulas in an image is a good idea, but I don't have any experience in writing tests for manim, so I don't know.

@leotrs
Copy link
Contributor

leotrs commented Aug 31, 2020

Thank you for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants