Skip to content

Conversation

@azarzadavila
Copy link
Contributor

Small PR to solve #184 as discussed on the issue.

@Aathish04 Aathish04 requested review from huguesdevimeux and leotrs and removed request for leotrs July 25, 2020 21:10
@Aathish04 Aathish04 added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Jul 25, 2020
@Aathish04 Aathish04 linked an issue Jul 26, 2020 that may be closed by this pull request
@huguesdevimeux huguesdevimeux self-requested a review July 29, 2020 20:04
@leotrs
Copy link
Contributor

leotrs commented Aug 2, 2020

LGTM. @huguesdevimeux can you please open a new issue to discuss how to test this? Thanks.

@leotrs leotrs merged commit d9c0734 into ManimCommunity:master Aug 2, 2020
@huguesdevimeux
Copy link
Member

huguesdevimeux commented Aug 2, 2020

@leotrs I added test_CONFIG directory in #227

@azarzadavila azarzadavila deleted the config-no-cli branch August 3, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Impossible to use a custom manim.cfg when NOT running from CLI

4 participants