Skip to content

macOS: build a shared library in wheels #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 1, 2022
Merged

macOS: build a shared library in wheels #71

merged 12 commits into from
Jan 1, 2022

Conversation

@naveen521kk
Copy link
Member

@naveen521kk naveen521kk commented Dec 31, 2021

No description provided.

@PhilippImhof
Copy link
Member

PhilippImhof commented Dec 31, 2021

What are we doing about the failing tests?

@naveen521kk
Copy link
Member Author

naveen521kk commented Dec 31, 2021

What are we doing about the failing tests?

I know why the tests were failing https://www.msys2.org/news/#2021-12-21-potential-incompatibilities-with-newer-python-setuptools, I will fix them soon.

@naveen521kk naveen521kk linked an issue Dec 31, 2021 that may be closed by this pull request
macOS: Wheels in v0.4.0 isn't working #70
Closed
@naveen521kk
Copy link
Member Author

naveen521kk commented Dec 31, 2021

Also, it would be better if you test whether the tests work with the in the PR: ManimCommunity/manim#2341

@PhilippImhof
Copy link
Member

PhilippImhof commented Dec 31, 2021

I will do so, probably tomorrow (UTC+1)

@naveen521kk
Copy link
Member Author

naveen521kk commented Dec 31, 2021

What are we doing about the failing tests?

Normal windows test also fails, I just thought msys2 one failed. I will see what is really happening.

PhilippImhof
PhilippImhof approved these changes Jan 1, 2022
View reviewed changes
Copy link
Member

@PhilippImhof PhilippImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested pre-built wheels locally.

@PhilippImhof
Copy link
Member

PhilippImhof commented Jan 1, 2022

Tested with code from ManimCommunity/manim#2341. Using these wheels, tests work. Using statically linked wheels from main branch, tests crash locally just like they do in CI.

@PhilippImhof PhilippImhof mentioned this pull request Jan 1, 2022
Merged
3 tasks
@PhilippImhof PhilippImhof merged commit 089dd6e into main Jan 1, 2022
@PhilippImhof PhilippImhof deleted the macos-wheels-fix branch January 1, 2022 12:43
@naveen521kk naveen521kk added the chore Maintenance label Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippImhof PhilippImhof PhilippImhof approved these changes

Assignees

No one assigned

Labels

chore Maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

macOS: Wheels in v0.4.0 isn't working

3 participants

@naveen521kk @PhilippImhof