Skip to content

Fix special case where "/" would match with all paths #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix special case where "/" would match with all paths #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/express/RoutePattern.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ public enum RoutePattern {
}
}

// I don't know if this special case is the best way to handle this but there was a one off error where
// any routes that use "/" for the pattern would match all routes
if case .root = pattern[0], pattern.count == 1 && escapedPathComponents.count > 1 { return nil }

// there have to be more or the same number of components in the path like
// things to match in the pattern ...
guard escapedPathComponents.count >= pattern.count else { return nil }
Expand Down