-
Notifications
You must be signed in to change notification settings - Fork 40
Create Mesh Gen Landice Test Case for Uummannaq/Disko Bay #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexolinhager
wants to merge
8
commits into
MPAS-Dev:main
Choose a base branch
from
alexolinhager:create_uummannaq_disko
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trhille
reviewed
Aug 18, 2025
# distance from ice margin to cull (km). | ||
# Set to a value <= 0 if you do not want | ||
# to cull based on distance from margin. | ||
cull_distance = -.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be -1.0?
19bd7d5
to
9fe92a5
Compare
Creates the option to maintain resolution in the ocean. Used to resolve fjords and bathymetry when coupling to MPAS-Ocean.
This commit creates the option to maintain high resolution in all ocean cells (same resolution as what is prescribed at outlet glacier termini). This is necessary to resolve the fjord geometry that thermal forcing parameterizations rely on. To reduce time when generating these higher resolution meshes, this commit also introduces an option to do an initial cull of the bedMachine dataset using the extent of the contintental shelf before generating the GIS mesh.
This commit moves the calculation of geom_points and geom_edges using a geojson of the gis contintental shelf extent to compass/landice/tests/greenland/mesh.py, instead of compass/landice/mesh.py. If this options is not being used, thn geom_points and geom_edges are calculated within build_cell_width, as per usual
Introduces new landice test case to generate a domain for the Uummannaq/Disko Bay region of GIS.
Create region masks for each tidewater outlet glacier in domain
Addresses bug introduced by the inclusion of the parallel_executable argument in interp_gridded2mali
52fbe2d
to
864d0c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new landice test case to generate a mesh for the Uummannaq Bay/Disko Bay region of GIS. Default
.cfg
file usesmax_res_in_ocn
capability fromhttps://github.com/MPAS-Dev/compass/pull/894
, so should be merged afterwards.Checklist
api.rst
) has any new or modified class, method and/or functions listedE3SM-Project
submodule has been updated with relevant E3SM changesMALI-Dev
submodule has been updated with relevant MALI changesTesting
in this PR) any testing that was used to verify the changes