Enable Option for High Res Mesh in Ocean #894
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates the option to maintain resolution in the ocean. Used to resolve fjords and bathymetry when coupling to MPAS-Ocean.
This commit creates the option to maintain high resolution in all ocean cells (same resolution as what is prescribed at outlet glacier termini). This is necessary to resolve the fjord geometry that thermal forcing parameterizations rely on. To reduce time when generating these higher resolution meshes, this commit also introduces an option to do an initial cull of the bedMachine dataset using the extent of the contintental shelf before generating the GIS mesh.
This commit moves the calculation of geom_points and geom_edges using a geojson of the gis contintental shelf extent to compass/landice/tests/greenland/mesh.py, instead of compass/landice/mesh.py. If this options is not being used, thn geom_points and geom_edges are calculated within build_cell_width, as per usual
trhille
requested changes
Aug 4, 2025
| @@ -31,7 +33,7 @@ def __init__(self, test_case): | |||
| Parameters | |||
| ---------- | |||
| test_case : compass.TestCase | |||
| The test case this step belongs to | |||
| The test case this step belongs to/ | |||
There was a problem hiding this comment.
Suggested change
| The test case this step belongs to/ | |
| The test case this step belongs to |
| @@ -265,12 +265,10 @@ def set_cell_width(self, section_name, thk, bed=None, vx=None, vy=None, | |||
| low_bed = section.getfloat('low_bed') | |||
| high_bed = section.getfloat('high_bed') | |||
|
|
|||
| # convert km to m | |||
| cull_distance = section.getfloat('cull_distance') * 1.e3 | |||
There was a problem hiding this comment.
We definitely don't want to remove culling by distance entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the option (
max_res_in_ocn=True) to maintain the highest resolution used on land ice cells in all ocean cells when generating the GIS MALI mesh. This is done to resolve fjord geometry and coastal bathymetry necessary to translate ocean properties to glacier termini when coupling MALI to MPAS-Ocean (or prescribing ocean forcing to MALI in standalone mode). As this has the potential to drastically increase mesh generation time, so there is an additional optiondefine_bnds_by_geojson=Truethat performs an initial cull of the BedMachine dataset according to the bounds set bycompass/landice/tests/greenland/gis_contShelfExtent_PS.geojsonbefore generating the mesh in Jigsaw.Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes