Skip to content

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Mar 27, 2021

This is helpful for creating masks and mapping files for meshes that already exist.

@xylar xylar added ocean in progress This PR is not ready for review or merging python package DEPRECATED: PRs and Issues involving the python package (master branch) labels Mar 27, 2021
@xylar xylar requested a review from mark-petersen March 27, 2021 15:05
@xylar xylar self-assigned this Mar 27, 2021
@xylar
Copy link
Collaborator Author

xylar commented Mar 27, 2021

Needs to be rebased onto #62

@xylar xylar force-pushed the add_make_diagnostics_files branch 2 times, most recently from 65daba3 to 7bac132 Compare April 8, 2021 10:53
@xylar xylar force-pushed the add_make_diagnostics_files branch 2 times, most recently from 4615d8c to 93adc1d Compare April 18, 2021 12:48
@xylar
Copy link
Collaborator Author

xylar commented Apr 24, 2021

This one will require #85, so closing it for now.

@xylar xylar closed this Apr 24, 2021
@xylar xylar reopened this Apr 30, 2021
@pep8speaks
Copy link

pep8speaks commented Apr 30, 2021

Hello @xylar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 60:80: E501 line too long (96 > 79 characters)

Comment last updated at 2021-04-30 08:30:03 UTC

xylar added 2 commits April 30, 2021 08:41
This is helpful for creating masks and mapping files for meshes
that already exist.
@xylar xylar force-pushed the add_make_diagnostics_files branch from 93adc1d to 1c985c2 Compare April 30, 2021 06:42
@xylar xylar removed the request for review from mark-petersen April 30, 2021 06:55
@xylar xylar removed the in progress This PR is not ready for review or merging label Apr 30, 2021
@xylar xylar marked this pull request as ready for review April 30, 2021 06:55
@xylar
Copy link
Collaborator Author

xylar commented Apr 30, 2021

Testing

I ran this new test case on Chrysalis. The steps were:

  1. set up the test case as usual:
python -m compass setup -n 82 -p ../compass/MPAS-Model/ocean/chrys_intel/ -w /lcrc/group/e3sm/ac.xylar/compass_1.0/chrysalis/test_20210430/diag_files
cd /lcrc/group/e3sm/ac.xylar/compass_1.0/chrysalis/test_20210430/diag_files/ocean/global_ocean/make_diagnostics_files/
  1. In the test case (not the step) directory, make a symlink to the mesh:
ln -s /lcrc/group/e3sm/public_html/inputdata/ocn/mpas-o/WCAtl12to45E2r4/ocean.WCAtl12to45E2r4.210318.nc
  1. Edit the config file:
[make_diagnostics_files]
mesh_name = WCAtl12to45E2r4
mesh_filename = ocean.WCAtl12to45E2r4.210318.nc
cores = 36
with_ice_shelf_cavities = False
  1. On a compute node:
source load_compass_env.sh
python -m compass run

The test ran successfully and produced the expected diagnostics files in the assembled_files directory:

assembled_files/diagnostics/mpas_analysis/maps/:
map_WCAtl12to45E2r4_to_0.5x0.5degree_bilinear.nc
map_WCAtl12to45E2r4_to_6000.0x6000.0km_10.0km_Antarctic_stereo_bilinear.nc
map_WCAtl12to45E2r4_to_6000.0x6000.0km_10.0km_Arctic_stereo_bilinear.nc

assembled_files/diagnostics/mpas_analysis/region_masks/:
WCAtl12to45E2r4_antarcticRegions20200621.nc
WCAtl12to45E2r4_arcticOceanRegions20201130.nc
WCAtl12to45E2r4_arcticSeaIceRegions20201130.nc
WCAtl12to45E2r4_ismip6Regions20210201.nc
WCAtl12to45E2r4_mocBasinsAndTransects20210331.nc
WCAtl12to45E2r4_oceanBasins20200621.nc
WCAtl12to45E2r4_oceanSubbasins20201123.nc
WCAtl12to45E2r4_transportTransects20210323.nc

I also ran the qu240_for_e3sm test suite to make sure things have not been broken by these changes. I didn't compare with a baseline.

@xylar xylar merged commit d598d51 into MPAS-Dev:master Apr 30, 2021
@xylar xylar deleted the add_make_diagnostics_files branch April 30, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ocean python package DEPRECATED: PRs and Issues involving the python package (master branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants