This repository was archived by the owner on Oct 23, 2020. It is now read-only.
Remove unused 'physics_addtend' routine #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the MPAS v5.0 release, the physics_addtend routine was replaced by the physics_get_tend routine in order to allow us to obtain tendencies from physics schemes only once per full dynamics step. When the physics_get_tend routine was introduced, the physics_addtend routine was left in the mpas_atmphys_todynamics.F file. We can now safely remove this routine.
|
OK, that sounds good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge removes the unused physics_addtend routine with no change to results.
Prior to the MPAS v5.0 release, the physics_addtend routine was replaced by
the physics_get_tend routine in order to allow us to obtain tendencies from physics
schemes only once per full dynamics step. When the physics_get_tend routine was
introduced, the physics_addtend routine was left in the mpas_atmphys_todynamics.F
file. We can now safely remove this routine.