Add start/stop time activation logic to MPAS_Alarm #1362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 26, 2025 17:06
Added startTime and stopTime fields to MPAS_Alarm_type in mpas_timekeeping_types.inc. Updated logic in mpas_add_clock_alarm, mpas_in_ringing_envelope, and mpas_reset_clock_alarm to activate and deactivate alarms based on whether the current clock time falls within the open interval defined by these times. Currently, this feature only works for forward clocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds start and stop times to
MPAS_Alarmwith activation logic. ThestartTimeandstopTimefields were introduced inmpas_timekeeping_types.inc, and the logic inmpas_add_clock_alarm,mpas_in_ringing_envelope, andmpas_reset_clock_alarmwas updated to ensure alarms are only active when the current clock time falls within the defined open interval. At this stage, the feature is only supported for forward clocks.