Chemistry stub modules for MUSICA MICM #1360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/musica, with Makefiles. Modified core_atmosphere/Makefile to build chemistry source. Added MUSICA MICM stub modules chemistry/mpas_atm_chemistry.F and chemistry/musica/mpas_musica.F.
K20shores
approved these changes
Aug 25, 2025
…at the end of atm_core_init in mpas_atm_core.F.
…t, etc, for consistency with MUSICA and the rest of MPAS.
mattldawson
reviewed
Sep 2, 2025
K20shores
approved these changes
Sep 2, 2025
mattldawson
reviewed
Sep 15, 2025
Comment on lines
+7
to
+9
| all: | ||
| ./../tools/manage_externals/checkout_externals --externals ./../Externals.cfg | ||
| $(MAKE) core_mpas_musica core_chemistry |
There was a problem hiding this comment.
Have you tested with w/o including MUSICA library in the build? I think we should exclude the mpas_musica.F file in the build when MUSICA is not linked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module chemistry/mpas_atm_chemistry.F has non-implemented stub subroutines for
init_chemistry(will callmusica_initfrom mpas_musica)step_chemistry(will callmusica_stepfrom mpas_musica)finalize_chemistry(will callmusica_finalizefrom mpas_musica)chemistry/musica/mpas_musica.F will define the mpas_musica module with the
musica_init,musica_step, andmusica_finalizesubroutines, also to be implemented.It uses and directly links to the MUSIC MICM modules
Also included is an error checking function
has_error_occurred.Note that the call to
music_initwill take as an argument the chemistry species defined as a new mpas_var_array to be implemented in a new framework module, for instance mpas_runtime_vars. The calling arguments will be further specified in subsequent PRs.