fix: another regression related to type narrow and generic since v3.10.1 #3088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3087
debugging and explanation: #3087 (comment)
中文版
3.10.1中 8ecec08 的改動應該是有問題目前出現另1個 regression issue 跟這改動有關
不過現在回看，該 fix 實際上過於複雜了 😂
而 issue 2776 的主要問題，似單純是 如果某 arg node 已經 compile 過，說明在相同 callstack 後邊需要被引用
=> 不能單純做 remove，否則會導致 error: index nil value
=> 換句話其實在 remove 後直接 recompile 一次應該就可以 🤔