Alternate fix for #1173 #1178
Merged
Alternate fix for #1173 #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sumneko
reviewed
May 28, 2022
sumneko
reviewed
May 28, 2022
tools/love-api.lua
Outdated
| for _, param in ipairs(func.variants[1].arguments or {}) do | ||
| for paramName in param.name:gmatch '[%a_][%w_]*' do | ||
| params[#params+1] = paramName | ||
| local optional = (param.type == 'table' and isTableOptional(param.table) or param.default) |
There was a problem hiding this comment.
Should be (param.default ~= nil)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the annotation files for LOVE API are built automatically, I updated the builder. If an argument is of table type its default field is always nil. I added a function that iterates over all the fields in the argument's table field and checks whether all of them have a default value. If so, I assign default = true to the argument. That should make the builder add the needed '?' next to the parameter name in the generated meta file.
See the love-api project's graphics module.