FIX: cannot handle parameters naming with underscore correctly. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aaa_bbbb_ccc, aaa_bbb
…ing encoding settings might make display incorrectly.
FlightControl-User
suggested changes
May 22, 2018
FlightControl-User
left a comment
FlightControl-User
left a comment
There was a problem hiding this comment.
This fix is damaging a previous fix, which is to ensure that @{} comments are correctly handled! Please don't accept this pull request!
Contributor
|
@FlightControl-User do you confirm the bug above ? Do you have any idea about a better fix ? 31726a8 seems out of topic but should be better handle encoding ? |
|
I am working on it and will do a pull request. |
|
The encoding change may be indeed good. I will embed that change into the package... |
|
Also a comment on markdown.... A word AI_A2A_DISPATCHER should not appear as AI_A2A_DISPATCHER ... with the A2A in italics... this should be a fix done in markdown |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
luadocumentor cannot handle parameters naming with underscore correctly. e.g.
aaa_bbb_ccc,aaa_bbbthis patch is to fix this problem