This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Optimized bytesToBytes32 #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dong77
approved these changes
Apr 23, 2018
dong77
added a commit
that referenced
this pull request
Apr 23, 2018
* added boilerplate code for multihash * minor * remove ringhash from RingMined event * Optimized bytesToBytes32() (#321) * minor improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization for #320.
Should significantly reduce gas cost by about ~7500 for every call (and there are quite a lot of calls to this function: 4 * ringSize calls to this function in submitRing).
It seems like the tests haven't been updated yet for all API changes in 1.6 so I cannot be sure how much gas is saved. But I tested the function externally and it should work fine.