-
Notifications
You must be signed in to change notification settings - Fork 14
Add link dependencies #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is one of 5 PR required to modify the build order scheme for LoopWorkspace from Build Order: Manual Order (which is deprecated and will be removed soon) to Build Order: Dependency Order. All 5 of these repositories for LoopWorkspace must be updated to enable modification of the xcscheme from These are the modified SHA used for the successful build tests for LoopWorkspace. This was tested with both Xcode build and Browser Build. Thanks to @kingst for his work in proposing these PR. This particular change for OmniKit has been tested for both LoopWorkspace and for Trio-dev. |
|
The added dependencies to OmniKit in this PR look good to me, but I still can't a Loop Workspace to successfully build using Dependency Order for the LoopWorkspace Scheme with all 5 of the suggested PR's after many attempts. I believe the problem is elsewhere (for now at least) as the build failures don't appear to be related to the added dependences in this PR which should be added. |
itsmojo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These updates seem reasonable. It would be good to be able to eventually build the LoopWorkspace using Dependency Order and these changes are a step towards that goal.
|
@itsmojo do you mind sharing the build errors? The errors are non-deterministic so my guess is that there is another dependency we missed |
|
I confirmed that I could build LoopWorkspace with both Manual and Dependency build order when the SHA noted in this comment were used. The 5 PR are explicitly:
Merging these PR are a predecessor to selecting Dependency Build order in the Workspace; but do not require that change (which is why I tested both build orders). I did run into difficulties with some Mac-Xcode testing of Dependency Build Order for the Amplitude plugin that was resolved by quitting and restarting Xcode. (Configuration: starting from LoopWorkspace I also tested the PR changes with (private) Trio-dev workspace which has Dependency Build Order. (Trio-dev does not use the NightscoutRemoteCGM submodule or Amplitude). This was successful with Mac-Xcode and Browser Build. |
This PR adds build dependencies to enable Xcode's parallel build system, used in Trio-dev (and others). The new dependencies are:
I tested this in Trio-dev (build only)