Logic fix for 049 pod fault with concurrent temp basal commands #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
itsmojo
commented
Jan 18, 2025
itsmojo
commented
- Fixes Trio issue #455, see for more details
- Tweaks to runTemporaryBasalProgram() to avoid using stale podState
- Change enactBolus() to use same updated pod suspended testing logic
+ Fixes Trio issue #455, see for more details + Tweaks to runTemporaryBasalProgram() to avoid using stale podState + Change enactBolus() to use same updated pod suspended testing logic
marionbarker
approved these changes
Jan 18, 2025
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Status
This update is accepted by code review.
Code Review
- The 0x31 fix in the
runTemporaryBasalProgramfunction comes from replacing the stale podState (from line 1952) before the lock (at runSession) with the podState obtained inside the lock (line 1992) which can be used for subsequent podState checks - The modification to the
enactBolusfunction was not required but is good form to match the syntax of therunTemporaryBasalProgramfunction
The code changes from this PR and OmniBLE PR140 are identical.
This was referenced Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.