Cleaning up SettingsTableViewController a bit #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps2
pushed a commit
that referenced
this pull request
Aug 4, 2020
* LOOP-1200: Persist DeviceAlerts to CoreData Also: Squash removePendingAlert and removeDeliveredAlert into retractAlert * PR Feedback: Renaming * checkpoint * Checkpoint: back to codegen'd CoreData object (seems to work) * Remove bits about expiration until we know how/when we want to do it. * Shuffled some code around a little. * oops these changes weren't staged. * Add unit tests, remove query support (for another PR) * PR Feedback, more unit tests * PR feedback * Add a log line for when an alert is not found to update * PR Feedback: "flatten" Trigger so that it is queryable Stored trigger type as an Int16, trigger interval as an optional Double (NSNumber). * Add query using modification counter (#92) * Add query using modification counter * PR Feedback * LOOP-1200: Dump Alert database into Issue Report (#93) * LOOP-1200: Dump Alert database into Issue Report Added query by date, plus unit tests. * PR Feedback, plus some rework/refactor This takes @darin's suggestion, with some modifications :). Now, the Filter is part of the Anchor, which makes it so anchoring continues to apply the filter as appropriate. * LOOP-1200: alert persistence followups (#94) * Add query using modification counter * PR Feedback * LOOP-1200: Dump Alert database into Issue Report Added query by date, plus unit tests. * PR Feedback, plus some rework/refactor This takes @darin's suggestion, with some modifications :). Now, the Filter is part of the Anchor, which makes it so anchoring continues to apply the filter as appropriate. * LOOP-1200: Split alertIdentifier and managerIdentifier After talking with Paul, we determined that we will need to be able to either filter or group alerts by device, so it would be better to keep managerIdentifier separate now so it can be used in data queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.