Adding info to the Loop Pill (preamble) #683
Conversation
everyone may not want the Loop pill expanded. so to help with customization option, added a note.
|
|
|
and thanks again goes to @kenstack...this is a feature we've been asking for in our house. |
|
|
||
| //upload loopParams instead of just loopName | ||
| //that is the only pill that has the option to modify the text | ||
| let loopStatus = LoopStatus(name: loopParams, version: loopVersion, timestamp: statusTime, iob: iob, cob: cob, predicted: predicted, recommendedTempBasal: recommended, recommendedBolus: recommendedBolus, enacted: loopEnacted, failureReason: loopError) |
There was a problem hiding this comment.
Rather than overriding the "name" field, a new field/fields should be added to the upload structure in the rileylink_ios project.
There was a problem hiding this comment.
@ps2 I can do that no problem, but how will NS display it ? I dont think NS will just create a new pill. But I may be wrong on that!
There was a problem hiding this comment.
Yes, supporting this in NS would require an NS PR.
There was a problem hiding this comment.
@kenstack Is it a complicated thing?
There was a problem hiding this comment.
@Kdisimone @ps2 it is still possible to pull to the dev?
|
can we add this as a commented-out code option that people could turn on using customizations instruction? Until we get a more permanent solution PR'd into NS? |
4 participants
Based on user requests to have some info available without needing to click on the Loop pill to see inside...this brings a couple information pieces as a preamble by using the Loop name to transmit the info. Since not everyone would prefer this option, also left an easy way to undo the change in the code and could add it to the customization section quite easily.