Skip to content

Simplifying Rewind-Prime reconciliation #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Simplifying Rewind-Prime reconciliation #602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions Loop/Extensions/DoseStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ extension LoopDataManager {
value: basal.scheduleEntry.rate,
unit: .unitsPerHour
)

if isRewound {
isRewound = false
}
case is RewindPumpEvent:
eventType = .rewind

Expand All @@ -70,15 +66,14 @@ extension LoopDataManager {

If the fixed prime is cancelled, it is never recorded in history. It is possible to cancel a fixed prime and perform one manually some time later, but basal delivery will have resumed during that period.

On an x23 model pump, the point at which basal delivery resumes is unambiguous thanks to the BasalProfileStart event.
On older model pumps, we take the conservative approach and assume delivery is paused only between the Rewind and the first Prime event.
We take the conservative approach and assume delivery is paused only between the Rewind and the first Prime event.
*/
dose = DoseEntry(suspendDate: event.date)
isRewound = true
case is PrimePumpEvent:
eventType = .prime

if !model.recordsBasalProfileStartEvents && isRewound {
if isRewound {
isRewound = false
dose = DoseEntry(resumeDate: event.date)
}
Expand Down