Skip to content

Use color to indicate age of carbs on board label #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Use color to indicate age of carbs on board label #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions Loop/View Controllers/CarbAbsorptionViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,9 @@ final class CarbAbsorptionViewController: ChartsTableViewController, Identifiabl
}
reloadGroup.leave()
}
}

carbsOnBoard = state.carbsOnBoard
carbsOnBoard = state.carbsOnBoard
}

if refreshContext.remove(.targets) != nil {
if let schedule = manager.settings.glucoseTargetRangeSchedule {
Expand Down Expand Up @@ -216,11 +216,11 @@ final class CarbAbsorptionViewController: ChartsTableViewController, Identifiabl
self.carbTotal = carbTotal
}

self.carbsOnBoard = carbsOnBoard

self.tableView.reloadSections(IndexSet(integer: Section.entries.rawValue), with: .fade)
}

self.carbsOnBoard = carbsOnBoard

if let cell = self.tableView.cellForRow(at: IndexPath(row: 0, section: Section.totals.rawValue)) as? HeaderValuesTableViewCell {
self.updateCell(cell)
}
Expand Down Expand Up @@ -381,12 +381,25 @@ final class CarbAbsorptionViewController: ChartsTableViewController, Identifiabl
private func updateCell(_ cell: HeaderValuesTableViewCell) {
let unit = HKUnit.gram()

if let carbsOnBoard = carbsOnBoard {
if let carbsOnBoard = carbsOnBoard, carbsOnBoard.quantity.doubleValue(for: unit) > 0 {
cell.COBDateLabel.text = String(
format: NSLocalizedString("at %@", comment: "Format fragment for a specific time"),
timeFormatter.string(from: carbsOnBoard.startDate)
)
cell.COBValueLabel.text = carbFormatter.string(from: NSNumber(value: carbsOnBoard.quantity.doubleValue(for: unit)))

// Warn the user if the carbsOnBoard value isn't recent
let textColor: UIColor
switch carbsOnBoard.startDate.timeIntervalSinceNow {
case let t where t < .minutes(-30):
textColor = .staleColor
case let t where t < .minutes(-15):
textColor = .agingColor
default:
textColor = .secondaryLabelColor
}

cell.COBDateLabel.textColor = textColor
} else {
cell.COBDateLabel.text = nil
cell.COBValueLabel.text = carbFormatter.string(from: NSNumber(value: 0))
Expand Down