Skip to content

Use standard forecast for bolus recommendations. #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2017
Merged

Use standard forecast for bolus recommendations. #454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39d88f1
Use the normal forecast for bolusing.
ps2 Apr 22, 2017
2d30d76
remove semicolon
ps2 Apr 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions Loop/Managers/LoopDataManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,22 +838,7 @@ final class LoopDataManager {
insulinActionDuration: insulinActionDuration
)

// TODO: This was added in https://github.com/LoopKit/Loop/issues/370, but concerns were raised
// that this contradicts users expectations in https://github.com/LoopKit/Loop/issues/435
let bolusSafetyEffects = settings.enabledEffects.subtracting([.retrospection, .momentum])

return min(recommendation,
DoseMath.recommendBolusFromPredictedGlucose(
try predictGlucoseFromCurrentData(using: bolusSafetyEffects),
maxBolus: maxBolus,
glucoseTargetRange: glucoseTargetRange,
insulinSensitivity: insulinSensitivity,
basalRateSchedule: basalRates,
pendingInsulin: pendingInsulin,
minimumBGGuard: minimumBGGuard,
insulinActionDuration: insulinActionDuration
)
)
return recommendation
}

/// *This method should only be called from the `dataAccessQueue`*
Expand Down